Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GR-33955] Handle bundle instances in the heap in the localization optimized mode. #3956

Conversation

graalvmbot
Copy link
Collaborator

@graalvmbot graalvmbot commented Oct 27, 2021

In the OptimizedLocalizationSupport the bundles are stored in a map. In order to make the getContents methods unreachable, the bundles are initialized eagerly and the lookup methods are substituted. However, if there are bundle instances somewhere in the heap that were not put in the map, they won't be initialized and therefore accessing their content will cause runtime failures. Therefore, we visit each object in the heap and if it is a ResourceBundle, we eagerly initialize it.

@graalvmbot graalvmbot force-pushed the github/d-kozak/GR-33955/basicxmlparserstest_testerrormessage-is-broken branch from 7b25f37 to 3592e6c Compare October 27, 2021 10:38
@d-kozak d-kozak requested a review from pejovica October 27, 2021 12:41
@graalvmbot graalvmbot force-pushed the github/d-kozak/GR-33955/basicxmlparserstest_testerrormessage-is-broken branch from 3592e6c to 18e5660 Compare November 1, 2021 11:47
@graalvmbot graalvmbot merged commit 1e935d6 into master Nov 1, 2021
@graalvmbot graalvmbot deleted the github/d-kozak/GR-33955/basicxmlparserstest_testerrormessage-is-broken branch February 8, 2022 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants